Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1KB2] Reproduction adaptation to new structure and debug. #62

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

[1KB2] Reproduction adaptation to new structure and debug. #62

wants to merge 14 commits into from

Conversation

elodiegermani
Copy link
Collaborator

@elodiegermani elodiegermani commented Jul 20, 2023 •
edited
Loading

This Pull Request is related to issue #61

Changes proposed in this Pull Request:

  • Reproduction of team 1KB2
  • Preprocessing and run-level hand-tested.
  • Need to test subject-level and group-level.
  • Need to implement the test file.

Checklist:

  • Descriptive title
  • Targets the main branch
  • Changes are functional
  • My code is explicit and comments were added to it
  • Code conforms with PEP8
  • Tests were added for the changes and they complete successfully
  • Existing tests were updated (if needed) and they complete successfully
  • Documentation was updated

@elodiegermani elodiegermani reopened this Sep 21, 2023
@bclenet bclenet mentioned this pull request Sep 29, 2023
Open
@bclenet
Copy link
Collaborator

bclenet commented Oct 17, 2023

Hi @elodiegermani,

About this PR, you can do the following changes (that should help passing the checks) :

  • merge the current revision of the main branch into yours (repro_1KB2)
  • replace the line '1KB2': None, by '1KB2': 'PipelineTeam1KB2', in the narps_open/pipelines/__init__.py file
  • replace the test_execution method in tests/pipelines/test_team_1KB2.py with :
@staticmethod
@mark.pipeline_test
def test_execution():
    """ Test the execution of a PipelineTeam1KB2 and compare results """
    helpers.test_pipeline_evaluation('1KB2')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elodiegermani @bclenet @elodiegermani1